Skip to content

Cherry-pick: Fix autocomplete popup - #3 (#11224)#11227

Merged
aparajit-pratap merged 2 commits intoDynamoDS:RC2.9.0_masterfrom
aparajit-pratap:RC2.9.0_master
Nov 3, 2020
Merged

Cherry-pick: Fix autocomplete popup - #3 (#11224)#11227
aparajit-pratap merged 2 commits intoDynamoDS:RC2.9.0_masterfrom
aparajit-pratap:RC2.9.0_master

Conversation

@aparajit-pratap
Copy link
Contributor

  • fix autocomplete popup - part 3

  • revert unchanged file

  • fix failing test, fix analytics for node autocomplete

  • add null check

  • review comments

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

* fix autocomplete popup - part 3

* revert unchanged file

* fix failing test, fix analytics for node autocomplete

* add null check

* review comments
@aparajit-pratap aparajit-pratap changed the title Fix autocomplete popup - #3 (#11224) Cherry-pick: Fix autocomplete popup - #3 (#11224) Nov 3, 2020
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment. Thanks for the fix. Really great work

@QilongTang QilongTang added this to the 2.9.0 milestone Nov 3, 2020
@QilongTang
Copy link
Contributor

I restarted the self serve check

@aparajit-pratap
Copy link
Contributor Author

@QilongTang I have run these tests locally and they seem to pass. Merging this PR for now. Let's see if the CI failures continue to occur.

@aparajit-pratap aparajit-pratap merged commit c7a262e into DynamoDS:RC2.9.0_master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants