Cherry-pick: Fix autocomplete popup - #3 (#11224)#11227
Merged
aparajit-pratap merged 2 commits intoDynamoDS:RC2.9.0_masterfrom Nov 3, 2020
Merged
Cherry-pick: Fix autocomplete popup - #3 (#11224)#11227aparajit-pratap merged 2 commits intoDynamoDS:RC2.9.0_masterfrom
aparajit-pratap merged 2 commits intoDynamoDS:RC2.9.0_masterfrom
Conversation
* fix autocomplete popup - part 3 * revert unchanged file * fix failing test, fix analytics for node autocomplete * add null check * review comments
QilongTang
reviewed
Nov 3, 2020
QilongTang
approved these changes
Nov 3, 2020
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one comment. Thanks for the fix. Really great work
QilongTang
approved these changes
Nov 3, 2020
Contributor
|
I restarted the self serve check |
Contributor
Author
|
@QilongTang I have run these tests locally and they seem to pass. Merging this PR for now. Let's see if the CI failures continue to occur. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix autocomplete popup - part 3
revert unchanged file
fix failing test, fix analytics for node autocomplete
add null check
review comments
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of