Merged
Conversation
zeusongit
reviewed
Oct 22, 2020
| /// </summary> | ||
| /// <returns>collection of node search elements</returns> | ||
| internal IEnumerable<NodeSearchElement> GetMatchingNodes() | ||
| internal IEnumerable<NodeSearchElement> GetMatchingSearchElements() |
Contributor
There was a problem hiding this comment.
Any reason for this change?
Contributor
Author
There was a problem hiding this comment.
Renamed since the function itself does not really return nodes (usually referring to node models or node view models) but rather than search elements, just to reduce confusion in the future
zeusongit
approved these changes
Oct 22, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@aparajit-pratap @zeusongit Addressed the comments |
zeusongit
approved these changes
Oct 23, 2020
QilongTang
added a commit
that referenced
this pull request
Oct 23, 2020
* Default Node Suggestions * Make member internal * CleanUp * Comments * Comments
8 tasks
QilongTang
added a commit
that referenced
this pull request
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Add Default Node suggestions for case where suggestion algorithm returns no results. @zeusongit I think changes here will be related to your task as well.

Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@mjkkirschner @aparajit-pratap