Position node autocomplete UI against respective input port#11190
Merged
aparajit-pratap merged 11 commits intoDynamoDS:masterfrom Oct 20, 2020
Merged
Position node autocomplete UI against respective input port#11190aparajit-pratap merged 11 commits intoDynamoDS:masterfrom
aparajit-pratap merged 11 commits intoDynamoDS:masterfrom
Conversation
aparajit-pratap
changed the title
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
QilongTang
reviewed
Oct 19, 2020
aparajit-pratap
changed the title
Contributor
|
@aparajit-pratap looking great! 🙌 Can we simply change the initializing width to be 256 by default, then pick up actual width? Or is this only in one isolated case and could be different for other ones? |
Contributor
|
@aparajit-pratap Would you try https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/Controls/NodeAutoCompleteSearchControl.xaml#L10? They may end up both working but I think limiting on the control itself may be cleaner |
QilongTang
approved these changes
Oct 20, 2020
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
@aparajit-pratap LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-3174
Attempt at placing the node autocomplete UI aligned with the respective port.
This works as expected except for the first time you bring up the UI, for some reason. As can be seen in the gif, the first time, the UI is not spaced correctly from the port. It was observed that the reason for this is that the
ActualWidthof the control is 250 the first time and subsequently it is 256. I'm not sure why this is the case 😕Declarations
Check these if you believe they are true
*.resxfilesFYIs
@Amoursol