Focus extension when activated#11168
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Oct 9, 2020
Merged
Conversation
Modifies the mechanism used to add/display extensions to make sure the extension bar is actually visible and that the right tab is actually displayed.
QilongTang
reviewed
Oct 8, 2020
Contributor
There was a problem hiding this comment.
This LGTM. @mmisol I am wondering if it would be worth for a view level unit test. We have sample view extension there maybe we could guard this API. What do you think? If checking the visibility of right panel is tricky we can probably add UI automation for this.
Collaborator
Author
|
@QilongTang Added a unit test for this. Let me know if it looks good now. |
Contributor
|
@mmisol Perfect! Thanks for doing it |
Contributor
|
The regressions on self CI does not seem related but rather ASM related. I am merging to result from BRE pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Modifies the mechanism used to add/display extensions to make sure the
extension bar is actually visible and that the right tab is actually
displayed.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @reddyashish