Add icon for Solid.ByRuledLoft#11165
Merged
mmisol merged 3 commits intoDynamoDS:masterfrom Oct 6, 2020
Merged
Conversation
aparajit-pratap
requested changes
Oct 6, 2020
Contributor
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
@mmisol I think you also need to check in the icon png files.
Collaborator
Author
|
@aparajit-pratap They are embedded into the resx file |
Contributor
Contributor
|
@mmisol I think I know why the node description has not been updated. The code comments in IGeometryFactory.cs need to also be copied to ProtoGeometry. We have to do this manually for now as the T4 template auto-generation is broken currently. Hoewever, we can make that change later. If you could just add the png's, we can merge this PR. |
aparajit-pratap
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds icons created by Jingyi for the new node Solid.ByRuledLoft.
Here is a screenshot of how they look like in Dynamo:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @aparajit-pratap