[DYN-3109] Disallow Python Migration Assistant when a Python3 engine is selected#11158
[DYN-3109] Disallow Python Migration Assistant when a Python3 engine is selected#11158zeusongit merged 23 commits intoDynamoDS:masterfrom
Conversation
| </data> | ||
| <data name="PythonScriptEditorMigrationAssistantButtonTooltip" xml:space="preserve"> | ||
| <value>Migration Assistant to update your Python 2 scripts to Python 3.</value> | ||
| <value>Migration Assistant to update your Python 2 scripts to Python 3. Engine must be set to Python 2 version to work.</value> |
There was a problem hiding this comment.
@Amoursol @aparajit-pratap Any more opinion on the messaging?
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Look solid to me, using converter seems a good choice here
|
@zeusongit could you check the test failures. |
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
So is it true that without any hover effect, the only difference between the enabled and disabled state of the 2-3 button is that the tooltip appears and does not appear respectively?
There is also a slight difference in the border of the button. |
|
Running this branch on the BRE self CI to confirm the failures are real: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/725/ |
| </ProjectReference> | ||
| <ProjectReference Include="..\Libraries\PythonNodeModels\PythonNodeModels.csproj"> | ||
| <Project>{8872CA17-C10D-43B9-8393-5C5A57065EB0}</Project> | ||
| <Name>PythonNodeModels</Name> |
There was a problem hiding this comment.
hmm @zeusongit so now DynamoCoreWPF depends on PythonNodeModels, please add Private False to this entry to see if it helps the failing test issue.
There was a problem hiding this comment.
also please consider if we really want DynamoCoreWPF to depend on PythonNodeModels, it seems like a strange reference.
| using System; | ||
| using System.Globalization; | ||
| using System.Windows; | ||
| using System.Windows.Data; |
There was a problem hiding this comment.
Do we still need these references?
| using PythonNodeModels; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Globalization; |
There was a problem hiding this comment.
same question here. Are all of these used?
There was a problem hiding this comment.
yes these are used, removed the other unused ones.
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with a comment about using.
5 participants
Purpose
DYN-3109
Disallow Python Migration Assistant when a Python3 engine is selected
(PS: I don't know why the gif is so slow, was normal before exporting)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo