Add null-check#11144
Merged
aparajit-pratap merged 10 commits intoDynamoDS:NodeAutoCompletefrom Sep 24, 2020
Merged
Conversation
QilongTang
added a commit
that referenced
this pull request
Sep 29, 2020
* Initial Commit of NodeAutoComplete MVP * Clean Up * Fix a bug that left over search term was kept for next trigger * Changed to use alt + mouse left key down and change cursor to adapt to connection mode * Fix the in canvas node auto complete glitching issue with a click suppress * Comments * preference setting test * Add test * New Node AutoComplete * Comments * Comments * Use node suggestion API in node autocomplete UI (#11132) * update code comment * add APIs to return matching nodes for input ports * revert temporary changes made for testing * cleanup * merge api with UI * revert unwanted changes * Add null-check (#11144) * add null-check * Clean Up * Moving GetMatchingNodes API to search view model (#11146) * Moving GetMatchingNodes API to search view model * Clean Up * Comments * Create a dedicated test file to prepare for more unit tests * Comments * Comments * Comments * Comments Co-authored-by: aparajit-pratap <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add null-check