Dynamo core annotations 1-10#11103
Merged
aparajit-pratap merged 12 commits intoDynamoDS:masterfrom Oct 6, 2020
Merged
Conversation
**NODE: String from Object** -CHANGES: Rename str to string, obj to object, Output description: String representation of the object. -NOT APPLICABLE: Name has spaces, does not have DS Syntax -FUTURE EDITS: Retain Existing -> Pending explanation from Sol
**NODE: String from Array** -CHANGES: Rename str to string, arr to array -NOT APPLICABLE: Name has spaces, does not have DS Syntax -FUTURE EDITS: Retain Existing -> Pending explanation from Sol
**NODE: Function Apply** -CHANGES: Rename func to function, arg1 to argument1 func(args) to result, Description: Returns the result of a function with supplied arguments. Ex: arguments of a point and vector are applied to a translate function returning a translated point. -NOT APPLICABLE: Name has spaces, does not have DS Syntax, items is not zero indexed, doesnt pass object-type
**NODE: Function Compose** -CHANGES: Rename func0 to function0, fun to function Description: Returns a single function from multiple functions. Ex: the modulus and divide functions are composed into a single function to apply to a list. -NOT APPLICABLE: Name has spaces, does not have DS Syntax
**NODES: List.LaceShortest List.LaceLongest List.Combine** -CHANGES: Rename comb to combinator, list1 to list0, combined to list Input Description: function to use as combinator
**NODE: List.GroupByFunction** -CHANGES: Rename func to groupFunction, var[]..[] to list Description: Returns a new list grouped by a function. Description Inputs: groupFunction = function for grouping list groupedList = Grouped list
Tooltip FormulaPortDataResultToolTip was being used for String from Object output description
All indexes should start at 0
QilongTang
approved these changes
Sep 10, 2020
aparajit-pratap
requested changes
Sep 10, 2020
Eliminate groupByfunction search option as it is name of node and is not needed for search.
List.GroupByFunction output description updated to reflect type: type: var[]..[] (list of arbitrary rank/levels)
Contributor
|
JIRA task for LibG improvements added here: https://jira.autodesk.com/browse/DYN-3145 |
Amoursol
approved these changes
Sep 30, 2020
Contributor
|
@martinstacey please update the following: |
aparajit-pratap
previously approved these changes
Oct 1, 2020
aparajit-pratap
dismissed
their stale review
Some review comments are yet to be addressed.
Contributor
|
@martinstacey aside from @Amoursol's comments about changing |
…uct update input name combinator -> combineFunction
Contributor
Author
addressed in d5ab208 |
>type: var[]..[] (list of arbitrary rank/levels) to List of arbitrary rank/levels (type: var[]..[])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The following PR addresses nodes' names and descriptions to make them more descriptive for beginners. This is the first PR of the series. More PRs will come subsequently.
1) NODE: String from Object
-CHANGES: Rename str to string, obj to object, Output description: String representation of the object.
2) NODE: String from Array
-CHANGES: Rename str to string, arr to array
3) NODE: Output
-Autodesk will take care of making this node not appear on library
4) NODE: Function Apply
-CHANGES: Rename func to function, arg1 to argument0 func(args) to result,
Description: Returns the result of a function with supplied arguments. Ex: arguments of a point and vector are applied to a translate function returning a translated point.
5) NODE: CoordinateSystem.ByMatrix
-Autodesk will deprecate this node.
6) NODE: Function Compose
-CHANGES: Rename func0 to function0, fun to function
Description: Returns a single function from multiple functions. Ex: the modulus and divide functions are composed into a single function to apply to a list.
7) NODE: Function Compose
-CHANGES: Rename func0 to function0, fun to function
Description: Returns a single function from multiple functions. Ex: the modulus and divide functions are composed into a single function to apply to a list.
8) NODE: List.LaceShortest
-CHANGES: Rename comb to combinator, list1 to list0, combined to list
Input Description: function to use as combinator
9) NODE: List.LaceLongest
-CHANGES: Rename comb to combinator, list1 to list0, combined to list
Input Description: function to use as combinator
10) NODE: List.Combine
-CHANGES: Rename comb to combinator, list1 to list0, combined to list
Input Description: function to use as combinator
11) NODE: List.CartesianProduct (changed automatically by addressing nodes 8-10)
-CHANGES: Rename comb to combinator, list1 to list0, combined to list
Input Description: function to use as combinator
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@SHKnudsen
@Amoursol
@QilongTang
FYIs
-Autodesk should take care of making node Output not appear on library search and deprecate CoordinateSystem.ByMatrix
-Sol confirmed not renaming nodes that do not have DS syntax and starting all lists with 0 indexes.
-String from Object output was fixed to use appropriate tooltip