Update LibG to include optimize prune#11094
Merged
mmisol merged 2 commits intoDynamoDS:masterfrom Sep 2, 2020
Merged
Conversation
aparajit-pratap
approved these changes
Sep 2, 2020
alfredo-pozo
reviewed
Sep 2, 2020
src/DynamoCore/DynamoCore.csproj
Outdated
| <Resource Include="BuiltInAndOperators\BuiltIn.Migrations.xml" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Content Include="images\logo.png" /> |
Contributor
There was a problem hiding this comment.
@mmisol I suggest to not include the Nuget package logo inside the projects, what do you think @aparajit-pratap ?
Collaborator
Author
There was a problem hiding this comment.
I can remove it for this PR, but as it gets added automatically when updating the package, it will eventually slip in.
Contributor
There was a problem hiding this comment.
I'm thinking to change the icon of location on the nuspec file, so in the future, it won't be automatically added to the projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update version of LibG used to include the fix for Point.PruneDuplicates.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @alfredo-pozo
FYIs
@DynamoDS/dynamo