Merged
Conversation
Fixes issues related to the state of the pan icon not reflecting the actual current state. There were two problems preventing this from updating. Some actions did not seem to trigger a property change on IsPlanning and IsOrbiting at the BackgroundPreviewViewModel. There are properties with the same name in the local view model that get updated more consistently. Some actions were triggering property change events in the wrong place. These were moved to the right place. While there were no reported issues with IsOrbiting, this property should behave in the same way, so the same changes were applied.
zeusongit
approved these changes
Sep 2, 2020
Contributor
zeusongit
left a comment
zeusongit
left a comment
There was a problem hiding this comment.
Looks good, but maybe add some comments for some context like the once you removed in Escape() and ToggleOrbit().
Collaborator
Author
|
@zeusongit I didn't actually remove those comments. Just moved them to the |
Contributor
|
Ah.. ok, got it. |
QilongTang
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes issues related to the state of the pan icon not reflecting the
actual current state.
There were two problems preventing this from updating.
Some actions did not seem to trigger a property change on IsPlanning
and IsOrbiting at the BackgroundPreviewViewModel. There are properties
with the same name in the local view model that get updated more
consistently.
Some actions were triggering property change events in the wrong place.
These were moved to the right place.
While there were no reported issues with IsOrbiting, this property
should behave in the same way, so the same changes were applied.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @zeusongit
FYIs
@DynamoDS/dynamo