Add "keepalive" flag to CLI to enable loaded extensions to control process lifetime#11090
Merged
Dewb merged 3 commits intoDynamoDS:masterfrom Sep 4, 2020
Merged
Add "keepalive" flag to CLI to enable loaded extensions to control process lifetime#11090Dewb merged 3 commits intoDynamoDS:masterfrom
Dewb merged 3 commits intoDynamoDS:masterfrom
Conversation
sm6srw
approved these changes
Sep 3, 2020
Contributor
sm6srw
left a comment
sm6srw
left a comment
There was a problem hiding this comment.
I can't see any logic in the test failure. Looks like a sporadic failure to me. Other than that: LGTM!
Contributor
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
@Dewb could you give some context to this change? I may have missed the discussion if it took place elsewhere.
aparajit-pratap
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a
-k/--keepaliveflag to the CLI. This will launch the engine and wait for additional commands to be queued from loaded extensions; the process will not exit until a loaded extension shuts down the model.This adds a new boolean field to the public class
StartupUtils.CommandLineArguments.Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of