Fix custom node small icon load in library#11063
Merged
mmisol merged 2 commits intoDynamoDS:masterfrom Aug 27, 2020
Merged
Conversation
Icons for packages custom nodes (dyf files) were not loaded in the library. This was due to a bug that created a wrong url, which used a default name, instead of the custom node id.
Collaborator
Author
|
Before: After: |
Contributor
aparajit-pratap
left a comment
aparajit-pratap
left a comment
There was a problem hiding this comment.
@mmisol looks good but I think there are few regressions, probably because you've added a new package and the tests counting the total number of packages need to be updated.
Question about whether:
- icons can be added for zero touch nodes by following the steps in the wiki.
- the wiki for adding icons to custom nodes is accurate.
Collaborator
Author
|
@aparajit-pratap Will check those tests. For the example I'm showing here I followed those steps so I'd say it's accurate, only that the bug was preventing it from working. I did not check ZT nodes because the reported issue was not related to them. I can also do that but should not be related to this PR. As you can see in the code this is a custom node specific error condition. |
aparajit-pratap
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Icons for packages custom nodes (dyf files) were not loaded in the
library. This was due to a bug that created a wrong url, which used a
default name, instead of the custom node id.
Fixes #10669
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@reddyashish @aparajit-pratap
FYIs
@DynamoDS/dynamo