Skip Dispose() calls in Shutdown()#11054
Merged
QilongTang merged 2 commits intomasterfrom Aug 25, 2020
Merged
Conversation
mmisol
reviewed
Aug 25, 2020
Collaborator
mmisol
left a comment
There was a problem hiding this comment.
Just a minor comment regarding these changes.
We should also update TuneUp and the NodePropertyPalette, right? Any other place we may have documented this? Like a View extension sample?
src/WorkspaceDependencyViewExtension/WorkspaceDependencyViewExtension.cs
Show resolved
Hide resolved
mmisol
approved these changes
Aug 25, 2020
Collaborator
mmisol
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me
Contributor
Author
|
@mmisol I checked our implementation in https://developer.dynamobim.org/03-Development-Options/3-6-extensions.html and https://github.com/DynamoDS/DynamoSamples/blob/master/src/SampleViewExtension/SampleViewExtension.cs is actually correct. I will make PRs for TuneUp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
As a follow up of #10672. @mmisol found all Dispose() functions are called twice and I verified that it is indeed the case. So I am removing these dedicated calls to show extension authors that they will only need to implement Dispose() call in the future.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of