Skip to content

Changes to switch the LibG references#11049

Merged
QilongTang merged 20 commits intoDynamoDS:masterfrom
alfredo-pozo:newupdatelibgref
Aug 27, 2020
Merged

Changes to switch the LibG references#11049
QilongTang merged 20 commits intoDynamoDS:masterfrom
alfredo-pozo:newupdatelibgref

Conversation

@alfredo-pozo
Copy link
Contributor

@alfredo-pozo alfredo-pozo commented Aug 24, 2020

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR has the purpose to use the new LibG nuget packages instead of the references under "extern" folder https://jira.autodesk.com/browse/DYN-1889

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@aparajit-pratap

FYIs

@QilongTang

alfredo-pozo and others added 12 commits April 16, 2020 14:35
@alfredo-pozo
Merge pull request #2 from DynamoDS/master
ea5af46 
Update forked master branch
@alfredo-pozo
Merge pull request #4 from DynamoDS/master
43aa0a0 
Update forked master branch
@alfredo-pozo
Merge pull request #5 from DynamoDS/master
3e3af00 
Update forked master branch
@alfredo-pozo
Merge pull request #6 from DynamoDS/master
d6374cd 
Update master forked repository
@alfredo-pozo
Update forked master branch
f2c7269 
Update forked master branch
@alfredo-pozo
Update forked master branch
8cdace1 
Update forked master branch
@alfredo-pozo
Update forked master branch
e5ecfdd 
Update forked master branch
@alfredo-pozo
Update forked master branch
eb4f731 
Update forked master branch
@alfredo-pozo
Merge pull request #11 from DynamoDS/master
8a03eab 
Update master forked branch
@alfredo-pozo
Merge pull request #12 from DynamoDS/master
dc164c9 
Update master forked repository
@alfredo-pozo
Update master forked branch
382fd6e 
Update master forked branch
@alfredo-pozo
First version with changes to switch to LibG nuget packages
10b3438
alfredo-pozo and others added 3 commits August 25, 2020 18:41
@alfredo-pozo
Remove of unnecessary files
03fb78c
@alfredo-pozo
Update master forked branch
9877fad 
Update master forked branch
@alfredo-pozo
Merge branch 'master' into newupdatelibgref
973ebb7 
# Conflicts:
#	extern/LibG_224_0_1/LibG.AsmPreloader.Managed.dll
#	extern/LibG_224_0_1/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_224_0_1/LibG.Managed.dll
#	extern/LibG_224_0_1/LibG.ProtoInterface.dll
#	extern/LibG_224_0_1/LibG.dll
#	extern/LibG_224_0_1/LibGCore.dll
#	extern/LibG_224_4_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_224_4_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_224_4_0/LibG.Managed.dll
#	extern/LibG_224_4_0/LibG.ProtoInterface.dll
#	extern/LibG_224_4_0/LibG.dll
#	extern/LibG_224_4_0/LibGCore.dll
#	extern/LibG_225_0_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_225_0_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_225_0_0/LibG.Managed.dll
#	extern/LibG_225_0_0/LibG.ProtoInterface.dll
#	extern/LibG_225_0_0/LibG.dll
#	extern/LibG_225_0_0/LibGCore.dll
#	extern/LibG_226_0_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_226_0_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_226_0_0/LibG.Managed.dll
#	extern/LibG_226_0_0/LibG.ProtoInterface.dll
#	extern/LibG_226_0_0/LibG.dll
#	extern/LibG_226_0_0/LibGCore.dll
#	extern/ProtoGeometry/LibG.Interface.dll
#	extern/ProtoGeometry/ProtoGeometry.dll
#	extern/ProtoGeometry/en-US/ProtoGeometry.resources.dll
aparajit-pratap
aparajit-pratap reviewed Aug 26, 2020
View reviewed changes
aparajit-pratap
aparajit-pratap reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfredo-pozo couple of comments. Overall this looks great. Thanks also for updating the nuget so quickly!

aparajit-pratap
aparajit-pratap reviewed Aug 26, 2020
View reviewed changes
@aparajit-pratap aparajit-pratap mentioned this pull request Aug 26, 2020
Merged
alfredo-pozo and others added 4 commits August 26, 2020 14:30
@alfredo-pozo
Update master forked branch
c89c740 
Update master forked branch
@alfredo-pozo
Changes to not use hardcore path to libg_locale
c4945e0
@alfredo-pozo
Merge branch 'master' into newupdatelibgref
33a1b10 
# Conflicts:
#	extern/LibG_224_0_1/LibG.AsmPreloader.Managed.dll
#	extern/LibG_224_0_1/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_224_0_1/LibG.Managed.dll
#	extern/LibG_224_0_1/LibG.ProtoInterface.dll
#	extern/LibG_224_0_1/LibG.dll
#	extern/LibG_224_0_1/LibGCore.dll
#	extern/LibG_224_4_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_224_4_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_224_4_0/LibG.Managed.dll
#	extern/LibG_224_4_0/LibG.ProtoInterface.dll
#	extern/LibG_224_4_0/LibG.dll
#	extern/LibG_224_4_0/LibGCore.dll
#	extern/LibG_225_0_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_225_0_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_225_0_0/LibG.Managed.dll
#	extern/LibG_225_0_0/LibG.ProtoInterface.dll
#	extern/LibG_225_0_0/LibG.dll
#	extern/LibG_225_0_0/LibGCore.dll
#	extern/LibG_226_0_0/LibG.AsmPreloader.Managed.dll
#	extern/LibG_226_0_0/LibG.AsmPreloader.Unmanaged.dll
#	extern/LibG_226_0_0/LibG.Managed.dll
#	extern/LibG_226_0_0/LibG.ProtoInterface.dll
#	extern/LibG_226_0_0/LibG.dll
#	extern/LibG_226_0_0/LibGCore.dll
#	extern/ProtoGeometry/LibG.Interface.dll
#	extern/ProtoGeometry/ProtoGeometry.dll
#	extern/ProtoGeometry/en-US/ProtoGeometry.resources.dll
@alfredo-pozo
Changing copy of libg locale to be supported by mono build
a8e4646
QilongTang
QilongTang reviewed Aug 27, 2020
View reviewed changes
src/DynamoCore/DynamoCore.csproj
<ItemGroup />
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
<Choose>
<When Condition=" '$(OS)' != 'Unix' ">
Copy link
Contributor

@QilongTang QilongTang Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this section for?

Copy link
Contributor Author

@alfredo-pozo alfredo-pozo Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is to decide which powershell to use, on the Linux image for the mono-build validation we have Powershell Core available, otherwise we use the windows powershell

@QilongTang
Copy link
Contributor

QilongTang commented Aug 27, 2020 •
edited
Loading

@alfredo-pozo Does this mean after this PR, local Dynamo builds will only have libG for ASM 226?

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Aug 27, 2020

@alfarok Does this mean after this PR, local Dynamo builds will only have libG for ASM 226?

I think you mean @alfredo-pozo :)

@alfredo-pozo
Copy link
Contributor Author

alfredo-pozo commented Aug 27, 2020

@QilongTang We are downloading all the nuget packages of LibG: 226, 225, 224.4 and 224, and the projects have reference to 226, does that answer your question?

@QilongTang QilongTang merged commit fe807ad into DynamoDS:master Aug 27, 2020
@QilongTang QilongTang mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alfredo-pozo @QilongTang @aparajit-pratap