Fix layout issue hiding Python editor buttons#11042
Merged
mmisol merged 1 commit intoDynamoDS:masterfrom Aug 24, 2020
Merged
Conversation
This fixes an issue that partially hid the "More info" button in the Python editor window when the UI was shown in German language. In that case "Run" would display as "Ausführen" which pushed the content to the right causing the "More info" button to be trimmed because it fell out of the boundaries of its container. The issue is fixed by removing the parent grid, resulting in a simpler and more flexible layout.
Contributor
|
Thanks @mmisol Please also cherrypick after merging |
mmisol
added a commit
to mmisol/Dynamo
that referenced
this pull request
Aug 24, 2020
This fixes an issue that partially hid the "More info" button in the Python editor window when the UI was shown in German language. In that case "Run" would display as "Ausführen" which pushed the content to the right causing the "More info" button to be trimmed because it fell out of the boundaries of its container. The issue is fixed by removing the parent grid, resulting in a simpler and more flexible layout.
8 tasks
mmisol
added a commit
that referenced
this pull request
Aug 24, 2020
This fixes an issue that partially hid the "More info" button in the Python editor window when the UI was shown in German language. In that case "Run" would display as "Ausführen" which pushed the content to the right causing the "More info" button to be trimmed because it fell out of the boundaries of its container. The issue is fixed by removing the parent grid, resulting in a simpler and more flexible layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes an issue that partially hid the "More info" button in the
Python editor window when the UI was shown in German language. In that
case "Run" would display as "Ausführen" which pushed the content to the
right causing the "More info" button to be trimmed because it fell out
of the boundaries of its container.
The issue is fixed by removing the parent grid, resulting in a simpler
and more flexible layout.
Here is a screenshot of the button bar after the fix:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @reddyashish
FYIs
@DynamoDS/dynamo