Cherry pick: print in Python + fix#11013
Merged
mmisol merged 2 commits intoDynamoDS:RC2.8.0_masterfrom Aug 17, 2020
Merged
Conversation
* redirect print to DynamoConsol + update unit test * comment updates * Update CPythonEvaluator.cs
This fixes build issues that appeared after merging 'print' function changes for CPython3. Those changes moved the print function to the globalScope which caused the 'DynamoPrintLogsToConsole' test to fail. The reason for this is that Python unit tests, which don't use a model, still initialize the globalScope but do not provide a logger, making later logging tests fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Include changes from #11000 and #11007 in 2.8
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of