Migration assistant legal messages#10965
Merged
mmisol merged 87 commits intoDynamoDS:masterfrom Aug 6, 2020
Merged
Conversation
* add ScriptMigrator * Add visual difference viewer * Update PythonMigrationViewExtension.cs * Add tooltip description to migration assistant * updates * comment updates * comment updates
* add ScriptMigrator * Add visual difference viewer * Added methods for updating the ScriptEditors with the migrated code * Update PythonMigrationViewExtension.cs * Add tooltip description to migration assistant * updates * comment updates * comment updates * Update ScriptEditorWindow.xaml.cs * Update PythonMigrationViewExtension.csproj * Update PythonMigrationViewExtension.csproj * comment updates * Revert "comment updates" This reverts commit 2d2332a. * comment updates * Update PythonMigrationAssistantViewModel.cs * comment updates 2
* add ScriptMigrator * Add visual difference viewer * Added methods for updating the ScriptEditors with the migrated code * Update PythonMigrationViewExtension.cs * add mechanisme to save Python 2 backup * Add tooltip description to migration assistant * updates * comment updates * comment updates * Update ScriptEditorWindow.xaml.cs * Update PythonMigrationViewExtension.csproj * Update PythonMigrationViewExtension.csproj * comment updates * Revert "comment updates" This reverts commit 2d2332a. * comment updates * Update PythonMigrationAssistantViewModel.cs * comment updates 2 * small clean ups * Update PythonMigrationAssistantViewModel.cs
…ionAssistantTests
also allow for slightly larger vertical height for Before/After label as it was hard to spot
…ion-assistant-warning
mjkkirschner
reviewed
Aug 5, 2020
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs
Outdated
Show resolved
Hide resolved
radumg
reviewed
Aug 5, 2020
src/PythonMigrationViewExtension/MigrationAssistant/PythonMigrationAssistantViewModel.cs
Outdated
Show resolved
Hide resolved
mmisol
reviewed
Aug 5, 2020
Collaborator
mmisol
left a comment
mmisol
left a comment
There was a problem hiding this comment.
An additional comment. It's unclear to me what the dialog's initial position is. I saw it in the gif but also happened to me while running. Should it be centered on top of the diff viewer?
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantWarning.xaml
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/MigrationAssistant/PythonMigrationAssistantViewModel.cs
Show resolved
Hide resolved
src/PythonMigrationViewExtension/MigrationAssistant/PythonMigrationAssistantViewModel.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mmisol addressed the comments, should be good to go. |
mmisol
reviewed
Aug 6, 2020
Collaborator
mmisol
left a comment
mmisol
left a comment
There was a problem hiding this comment.
Thanks @SHKnudsen . Just noticed some minor issues and some texts that should be externalized as resources.
src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml.cs
Outdated
Show resolved
Hide resolved
src/PythonMigrationViewExtension/Controls/MigrationAssistantDisclaimer.xaml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a legal message to the Migration Assistant when the user wants to accept the changes proposed. the warning message has the option to
Do not show againwhich will store a text file with a timestamp and the name of the machine inAppData\Local\Dynamo.Disable warning dialog file
Migration Assistant warning dialog
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
FYIs
@mjkkirschner
@Amoursol
@radumg