add try catch to CLR Object Marshaler getStringValue#10952
Merged
mjkkirschner merged 2 commits intoDynamoDS:masterfrom Jul 30, 2020
Merged
add try catch to CLR Object Marshaler getStringValue#10952mjkkirschner merged 2 commits intoDynamoDS:masterfrom
mjkkirschner merged 2 commits intoDynamoDS:masterfrom
Conversation
add test
Contributor
|
@mjkkirschner can we verify that the ToString calls on these Revit/AutoCAD objects are throwing the exceptions and that they are the reason for the crash? |
Member
Author
|
I can try to reproduce locally with Revit, but the stack trace seems to imply that: |
aparajit-pratap
approved these changes
Jul 29, 2020
Member
Author
|
crashed before - after seems to execute ok. |
Contributor
|
@mjkkirschner it looks like the exception was occurring for only certain parameters and not all. In cases, where the exception is being thrown and caught, there should be empty strings, am I right? |
Member
Author
|
yep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Address the situation where a
ToStringcall on a clr object that is not null results in an exception - it turns out this happens quite frequently in Autocad and Revit.Declarations
Check these if you believe they are true
*.resxfiles