T1.4-Update ScriptEditorWindow#10930
Merged
radumg merged 2 commits intoDynamoDS:masterfrom Jul 29, 2020
Merged
Conversation
SHKnudsen
changed the title
QilongTang
reviewed
Jul 23, 2020
QilongTang
requested changes
Jul 23, 2020
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Super excited. I have been waiting for this so I can propose the dock button using the same style
7 tasks
mmisol
approved these changes
Jul 23, 2020
Collaborator
mmisol
left a comment
mmisol
left a comment
There was a problem hiding this comment.
Looks good to me.
I guess I would put 2->3 and ? next to each other, as they are related, but not my call :)
Collaborator
|
Ok, I'll bring that up at demo for @Amoursol to decide on placing, we can still change/rectify in the other PRs, but given it's been approved, merging this so it doesn't interfere with the other PRs. |
Contributor
|
I'm totally happy with putting the |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the Python ScriptEditor so buttons are aligned and only uses icons and tooltips.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
FYIs
@mjkkirschner
@QilongTang
@radumg