T1.2 accept/reject code changes proposed by the MigrationAssistant#10915
Merged
mmisol merged 24 commits intoDynamoDS:masterfrom Jul 23, 2020
Merged
T1.2 accept/reject code changes proposed by the MigrationAssistant#10915mmisol merged 24 commits intoDynamoDS:masterfrom
mmisol merged 24 commits intoDynamoDS:masterfrom
Conversation
* add ScriptMigrator * Add visual difference viewer * Update PythonMigrationViewExtension.cs * Add tooltip description to migration assistant * updates * comment updates * comment updates
* add ScriptMigrator * Add visual difference viewer * Added methods for updating the ScriptEditors with the migrated code * Update PythonMigrationViewExtension.cs * Add tooltip description to migration assistant * updates * comment updates * comment updates * Update ScriptEditorWindow.xaml.cs * Update PythonMigrationViewExtension.csproj * Update PythonMigrationViewExtension.csproj * comment updates * Revert "comment updates" This reverts commit 2d2332a. * comment updates * Update PythonMigrationAssistantViewModel.cs * comment updates 2
…ionAssistantTests
mmisol
reviewed
Jul 22, 2020
src/PythonMigrationViewExtension/PythonMigrationViewExtension.csproj
Outdated
Show resolved
Hide resolved
mmisol
reviewed
Jul 22, 2020
Collaborator
mmisol
left a comment
mmisol
left a comment
There was a problem hiding this comment.
Looks good to me but let's wait for Mike to confirm what we should do with the event attached to the model
mmisol
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds functionality to the
MigrationAssistantwhich allow users to accept or reject the proposed code changes. When code changes are accepted the Python Engine will automatically switch toCPython3. The code migration is part of the Dynamo undo stack, so clicking theRevertbutton will change the code back to the original state.Mechanism for saving a complete back-up of the existing .dyn file containing Ironpython2 code is being prepared on a separate PR
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
@QilongTang
FYIs
@mjkkirschner
@radumg