Marshall out iterables as lists in CPython#10894
Merged
mmisol merged 3 commits intoDynamoDS:masterfrom Jul 15, 2020
Merged
Conversation
Adds support for marshalling out iterables that are not lists or dictionaries using the CPython engine. In order to achieve this, the check PyIter.IsIterable was used, along with some extra considerations, mentioned in the source with comments.
| } | ||
|
|
||
| [Test] | ||
| public void NonListIterablesCanBeOutput() |
Member
There was a problem hiding this comment.
does this test hit the condition on line 204?
Collaborator
Author
There was a problem hiding this comment.
Not this test. One which failed without that part is this one https://github.com/DynamoDS/Dynamo/blob/master/test/Libraries/DynamoPythonTests/PythonEvalTestsWithLibraries.cs#L189
Member
There was a problem hiding this comment.
so it's currently failing?
Collaborator
Author
There was a problem hiding this comment.
No, sorry if I didn't say it right. That test does work and hits that line.
What I meant is that at some point during my development of this I noticed the test failed, which led me to add the block that spans from line 201 to 205.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds support for marshalling out iterables that are not lists or
dictionaries using the CPython engine. In order to achieve this, the
check PyIter.IsIterable was used, along with some extra considerations,
mentioned in the source with comments.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@DynamoDS/dynamo