Skip to content

Easily install missing IronPython extension package#10869

Merged
aparajit-pratap merged 15 commits intoDynamoDS:masterfrom
aparajit-pratap:dyn-2787
Jul 16, 2020
Merged

Easily install missing IronPython extension package#10869
aparajit-pratap merged 15 commits intoDynamoDS:masterfrom
aparajit-pratap:dyn-2787

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jul 9, 2020 •
edited
Loading

Purpose

Easily install missing IronPython extension package.
python_package

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@aparajit-pratap aparajit-pratap marked this pull request as ready for review July 10, 2020 16:39
mmisol
mmisol reviewed Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions related to this PR and the future. Probably something we should answer as a team.

What should be the strategy for releasing future versions of the Iron Python engine package? Should 2.7.9 be the version here and whenever 3.0.0 is released we deprecate the previous version of the package in PM (if that's possible)?

We talked about removing the migration functionality in Python Epic 8. I think we should make sure to do that at a time it is no longer relevant, which would have to be some time after we deprecate the 2.7.9 version of the Iron Python engine package. I'm not sure if it should be enough to infer some info about usage from Package Manager, by tracking downloads, or if we should use analytics to cover cases where users have already installed the package and are just using it.

@aparajit-pratap aparajit-pratap mentioned this pull request Jul 14, 2020
Merged
7 tasks
aparajit-pratap
aparajit-pratap commented Jul 16, 2020
View reviewed changes
src/PythonMigrationViewExtension/GraphPythonDependencies.cs
{
private ViewLoadedParams ViewLoaded { get; set; }
internal static readonly string PythonPackage = "DSIronPython_Test";
internal static readonly Version PythonPackageVersion = new Version(1, 0, 7);
Copy link
Contributor Author

@aparajit-pratap aparajit-pratap Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be updated once the IronPython extension is published to PM prod.

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Jul 16, 2020

What should be the strategy for releasing future versions of the Iron Python engine package? Should 2.7.9 be the version here and whenever 3.0.0 is released we deprecate the previous version of the package in PM (if that's possible)?

@mmisol, as discussed I think the strategy is to add new packages for new engine versions and make them available in the PM in the future.

@aparajit-pratap aparajit-pratap added the PTAL Please Take A Look 👀 label Jul 16, 2020
@aparajit-pratap aparajit-pratap mentioned this pull request Jul 16, 2020
Merged
7 tasks
@aparajit-pratap aparajit-pratap merged commit 65751e4 into DynamoDS:master Jul 16, 2020
@aparajit-pratap aparajit-pratap deleted the dyn-2787 branch July 16, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

@zeusongit zeusongit zeusongit left review comments

@QilongTang QilongTang QilongTang approved these changes

+1 more reviewer

@mmisol mmisol mmisol left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PTAL Please Take A Look 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aparajit-pratap @mjkkirschner @QilongTang @mmisol @zeusongit