Skip to content

[DYN-2755] Preview disabled nodes can be renamed with double click#10854

Merged
zeusongit merged 15 commits intoDynamoDS:masterfrom
zeusongit:rename-preview
Jul 9, 2020
Merged

[DYN-2755] Preview disabled nodes can be renamed with double click#10854
zeusongit merged 15 commits intoDynamoDS:masterfrom
zeusongit:rename-preview

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jul 7, 2020

Purpose

DYN-2755
This adds the ability to the preview disabled nodes to interpret the double click event and open rename dialog box.
UI Automation Test PR: #24

Before:
preview-before

After:
preview-after2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.

Reviewers

@DynamoDS/dynamo

Zeus1717 added 14 commits March 20, 2020 13:12
@zeusongit zeusongit marked this pull request as draft July 8, 2020 00:51
@zeusongit zeusongit added the WIP label Jul 8, 2020
@zeusongit zeusongit removed the WIP label Jul 8, 2020
@zeusongit zeusongit marked this pull request as ready for review July 8, 2020 20:55
@zeusongit zeusongit requested review from QilongTang and mmisol July 8, 2020 20:56
Copy link
Collaborator

@mmisol mmisol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zeusongit zeusongit merged commit 6256f0b into DynamoDS:master Jul 9, 2020
@zeusongit zeusongit deleted the rename-preview branch July 9, 2020 17:34
@zeusongit zeusongit restored the rename-preview branch July 9, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants