[DYN-2757] Added system.collections.immutable dependency to DynamoVisualProgramming.Core nuget package#10778
Merged
zeusongit merged 4 commits intoDynamoDS:masterfrom Jun 18, 2020
Merged
Conversation
zeusongit
changed the title
Contributor
|
Thanks for updating the Readme. |
QilongTang
approved these changes
Jun 18, 2020
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Same here. Thank you for fixing the readme! Did you had a chance to build it locally and use Nuget explorer to check the result package?
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Jun 24, 2020
QilongTang
pushed a commit
that referenced
this pull request
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DesignScriptBuiltin.dll contains our dictionary type which is implemented using immutable dictionaries, but we have not marked that as a nuget dependency of our package, therefore this PR is adding that as the dependency.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo