Changes to nuspec files to work with 4.8 .Net Framework#10732
Merged
QilongTang merged 7 commits intoDynamoDS:masterfrom Jun 8, 2020
Merged
Changes to nuspec files to work with 4.8 .Net Framework#10732QilongTang merged 7 commits intoDynamoDS:masterfrom
QilongTang merged 7 commits intoDynamoDS:masterfrom
Conversation
Update forked master branch
Update forked master branch
Update forked master branch
Update master forked repository
Update forked master branch
…cated elements and warnings when the nuget packages are created
mjkkirschner
reviewed
Jun 4, 2020
tools/NuGet/template-artifactory/DynamoVisualProgramming.DynamoCoreRuntime.nuspec
Show resolved
Hide resolved
QilongTang
reviewed
Jun 4, 2020
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="DSIronPython.dll" target="lib\net48" /> |
Contributor
There was a problem hiding this comment.
@mjkkirschner Do you recall why we include IronPython in nuget? Do we need to include CPython now?
Member
|
Yeah was wondering this as well - let’s not add more here and instead shrink the Api when we can
… On Jun 4, 2020, at 8:45 AM, Aaron (Qilong) ***@***.***> wrote:
@QilongTang commented on this pull request.
In tools/NuGet/template-nuget/DynamoVisualProgramming.Core.nuspec:
> + 7) ProtoCore.dll
+ 8) DesignScriptBuiltin.dll
+ 9) VMDataBridge.dll</description>
+ <summary>This package contains the core assemblies for Dynamo.</summary>
+ <copyright>Copyright Autodesk 2019</copyright>
+ <dependencies>
+ <group targetFramework=".NETFramework4.8">
+ <dependency id="Prism" version="4.1"/>
+ <dependency id="NUnit" version="2.6.3"/>
+ <dependency id="DynamoVisualProgramming.ZeroTouchLibrary" version="$Version$"/>
+ <dependency id="Newtonsoft.Json" version="8.0.3"/>
+ </group>
+ </dependencies>
+ </metadata>
+ <files>
+ <file src="DSIronPython.dll" target="lib\net48" />
@mjkkirschner Do you recall why we include IronPython in nuget? Do we need to include CPython now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
|
@alfredo-pozo @mjkkirschner Merging this, the self serve error does not look related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR is to update the generated Nuget packages of Dynamo to 4.8 .Net Framework and is related to the JIRA task https://jira.autodesk.com/browse/DYN-2685
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@mjkkirschner