[DYN-2206] Reset engine on scheduler thread upon creation of new workspace#10687
Merged
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom May 22, 2020
Merged
[DYN-2206] Reset engine on scheduler thread upon creation of new workspace#10687aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
aparajit-pratap merged 2 commits intoDynamoDS:masterfrom
Conversation
7 tasks
Member
|
@aparajit-pratap this looks good, is there anyway to test this in core? |
Contributor
Author
@mjkkirschner I've added a test to verify that function definitions are cleared on creating a new workspace. |
Collaborator
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Brings back the changes proposed in #10113, the difference being that now we are being careful to reset the engine on the scheduler thread so that in the context of D4R, the engine reset and consequently any Revit element cleanup takes place as a transaction on the Revit idle thread thus preventing the crash in #10281.
As mentioned in #10113, this also fixes https://jira.autodesk.com/browse/DYN-1021.
Declarations
This fix has been tested with the Revit-Dynamo samples in Revit2020 and the crash is no longer reproducible. To verify I have tried doing the reset outside of the scheduler thread and have been able to reproduce the crash with the same steps.
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo