[DYN-2655]: Fix crash for badly formatted xml docs on ZT node#10674
Merged
aparajit-pratap merged 4 commits intoDynamoDS:masterfrom May 21, 2020
Merged
[DYN-2655]: Fix crash for badly formatted xml docs on ZT node#10674aparajit-pratap merged 4 commits intoDynamoDS:masterfrom
aparajit-pratap merged 4 commits intoDynamoDS:masterfrom
Conversation
Contributor
|
LGTM |
mmisol
approved these changes
May 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-2655
Take the following example of XML documentation on a zero touch method. Strictly speaking it isn't a badly formatted XML as there is no XML exception that is thrown, however it does result in a different unhandled exception from our own code that parses the XML and converts it into node tooltips. Notice that here the
<returns>tag following the<params>tag was missing that led to the exception and consequently the crash.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo