WIP: support Python 3 evaluation engine#10472
Closed
Dewb wants to merge 7 commits intoDynamoDS:masterfrom
Closed
Conversation
Contributor
|
FYI: @DynamoDS/dynamo |
Member
|
@Dewb - not really super relevant -but something seems wrong with this solution - all 3 build checks failed trying to parse the .sln? |
7 tasks
6 tasks
Contributor
Author
|
Now covered by #10548, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds infrastructure for selectable Python engines in the Python Script and Python Script From String nodes, and in addition to the original IronPython 2.7 engine, also supports a CPython 3.7 evaluation engine via Python.NET.
Engines are selectable via anew
Enginestring property on the node, but there is no UI for this property yet, it can only be specified in the .dyn file.Todo before merge:
Declarations
Check these if you believe they are true
*.resxfilesAPI Changes
PythonNodeBase.Engine