add new extension LibraryViewExtension (based on Microsoft WPF.WebView)#10233
Closed
mjkkirschner wants to merge 9 commits intoDynamoDS:masterfrom
Closed
add new extension LibraryViewExtension (based on Microsoft WPF.WebView)#10233mjkkirschner wants to merge 9 commits intoDynamoDS:masterfrom
mjkkirschner wants to merge 9 commits intoDynamoDS:masterfrom
Conversation
add make core internals visible add duplicate files as required
added package references
namespace adds dynamo use new namespace to reference resources that are embedded.
Member
Author
|
unfortunately it looks like while this works okay in DynamoSandbox, it does not work in more complex hosts - which makes it rather useless - I will send a PR soon for a |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
replaces #10222
This PR differs in a few way:
Dynamo.LibraryViewExtensionMSWebViewto avoid conflicts between them incase somehow these dlls are loaded at the same time by accident.here is what I know we need to do (not all of this will be done in this PR)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of