restore behavior of extension loadNodeLibrary method (#10187)#10196
Merged
mjkkirschner merged 1 commit intoDynamoDS:RC2.5.0_masterfrom Dec 5, 2019
Merged
restore behavior of extension loadNodeLibrary method (#10187)#10196mjkkirschner merged 1 commit intoDynamoDS:RC2.5.0_masterfrom
mjkkirschner merged 1 commit intoDynamoDS:RC2.5.0_masterfrom
Conversation
* raise event when importing zt node via LoadNodeLibrary method to restore behavior * Update DynamoModel.cs review comments * test passes with this change- do not add duplicate search entires * update behavior of custom node test - no longer entries with the same guid as seperate entries add API test improve equality and hashcode * add new method to extensionLibraryLoader use this to revert to old behavior for API users while keeping package manager behavior unchanged update tests to use new method * review comments (cherry picked from commit 0605400)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherrypick:
#10187