Skip to content

Replace package filter icon with text #10181

Merged
QilongTang merged 4 commits intomasterfrom
FilterByReplaceIconWithText
Dec 2, 2019
Merged

Replace package filter icon with text #10181
QilongTang merged 4 commits intomasterfrom
FilterByReplaceIconWithText

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 2, 2019 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

DYN-2317
As a Dynamo user, I want to easily locate package filter within package manager.

This PR does not touch the WPF control id so any existing tests should still work.

Before:
image

After:
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@Amoursol

@Amoursol
Copy link
Contributor

Amoursol commented Dec 2, 2019

@QilongTang is it possible to make there more of a distinction between both buttons? There doesn't appear to the naked eye to be much of a gap between the two. Beyond that, LGTM.

@QilongTang
Copy link
Contributor Author

QilongTang commented Dec 2, 2019

@Amoursol Thanks! Added some distinction so that clearer two buttons for user. Let me know.

@mjkkirschner
Copy link
Member

mjkkirschner commented Dec 2, 2019

looks good to me - @smangarole are there any UI automation tests which will be effected by this?

@mjkkirschner mjkkirschner added the LGTM Looks good to me label Dec 2, 2019
@QilongTang QilongTang merged commit f0337bd into master Dec 2, 2019
@QilongTang QilongTang deleted the FilterByReplaceIconWithText branch December 2, 2019 19:15
QilongTang added a commit that referenced this pull request Dec 2, 2019
@QilongTang
Replace package filter icon with text (#10181)
883a7a7 
* Replace Filter By icon with text

* remove fa reference

* Update Button Separation
@QilongTang QilongTang mentioned this pull request Dec 2, 2019
Merged
7 tasks
QilongTang added a commit that referenced this pull request Dec 2, 2019
@QilongTang
Replace package filter icon with text (#10181) (#10185)
00640a1 
* Replace Filter By icon with text

* remove fa reference

* Update Button Separation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

LGTM Looks good to me

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @Amoursol @mjkkirschner