get ready for removal of sys.win.int - manually hookup events#10162
get ready for removal of sys.win.int - manually hookup events#10162mjkkirschner wants to merge 5 commits intoDynamoDS:masterfrom
Conversation
…3 version - same version shipped by revit.
also brittle.
mjkkirschner
changed the title
|
@mjkkirschner what is the change you've made to the |
|
Hey @aparajit-pratap - I forgot to include this in the PR descriptions, but have mentioned it a few times - it's arguable if we can remove the dll at this time completely as we still have a public type that inherits from it
it's kind of an odd case as it's in DynamoCoreWPF and is used in our views, but someone could have used or derived from this type. So my change to that dll was to update it to the 3.x version. I should add the obsolete attribute to that type here. |
Oh so you've just updated the version here? |
|
yes updated the version - and while the |
2 participants
Purpose
One approach to removing system.windows.Interactivity -
it's ugly and brittle but it does load - and mostly works...
when the portViewModel collection is modified we hook up some event handlers and redirect these to the commands they are intended to call on the portViewmodel...
We need to keep track of the observableCollection of
portViewModelsand remove the handlers etc etc.meh.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of