Merged
Conversation
edited to work with vs2019
Contributor
|
LGTM |
mjkkirschner
reviewed
Nov 5, 2019
Member
|
@zeusongit @QilongTang @aparajit-pratap do you think the build should fail if this transform fails? Right now it does not. |
mjkkirschner
approved these changes
Nov 5, 2019
Member
mjkkirschner
left a comment
There was a problem hiding this comment.
@zeusongit this looks good, I just have two questions.
Contributor
|
I dont think the build should fail for everyday user.. 3rd party dev should not worry about this I think. @mjkkirschner @aparajit-pratap What do you think? |
Contributor
|
I am going to merge this, at the same time uninstalling VS2017 locally on my machine to test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited transform_all.bat to work with vs2019, utilizing vswhere.exe utility.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
https://jira.autodesk.com/browse/DYN-2152
AssemblySharedInfo.tt file was not being updated with the latest build no., as the paths for vs were not defined.
Now, by using vswhere tool, vs path is provided irrespective of the version used to build the project.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs