Convert BigInteger to Int64 when possible from Python#10096
Convert BigInteger to Int64 when possible from Python#10096aparajit-pratap merged 5 commits intoDynamoDS:masterfrom
Conversation
|
Excellent! Any reason this has to be done inside the generic marshaller execution rather than by defining a custom marshaler for |
|
Looks like we have custom The |
I agree that the marshaling for BigInteger can be specific to the output marshaling. Will make the necessary changes.
|
|
@aparajit-pratap would you mind filing this internally? |
|
Added unit test, addressed review comments about registering the I haven't moved |
|
LGTM with one comment |
|
FYI the IronPython issue that prompted this is supposedly fixed in IronPython 2.7.9. |
|
hmm - so this test should have passed already - since we are using ironPython 2.7.9. @aparajit-pratap do we now include system.numerics in our shipped binaries or this is loaded from the GAC? It will be useful to know as we should communicate this in the release notes of 2.5 |
|
I reverted my change leaving the test to test locally. It didn't pass. |
|
@aparajit-pratap your test also includes a big integer check (last type in your list) - perhaps that gets marshalled to long now in all cases? |
|
here's Mike's issue: |
|
It is loaded from GAC and referenced from |

Purpose
https://autodesk.slack.com/archives/CED3BF6C9/p1571942488031200

JIRA: https://jira.autodesk.com/browse/DYN-2262
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@Dewb