Plugin directory exists and write checks in options #387
Conversation
WalkthroughAdds directory validation UI to the plugin-path fragment: controller now accepts ApplicationDefaults, computes existence/read/write checks, exposes DirectoryChecks/DirectoryCheck types, and updates three new labels with SVG check/cross icons. FXML and CSS updated; constructor call sites adjusted. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as PluginPath TextField
participant Controller as PluginPathFragmentController
participant SVG as SVGPaths (check/cross)
participant Labels as {Exist / Read / Write Labels}
User->>UI: enter or change plugin path
UI->>Controller: notify text change / refresh()
activate Controller
Controller->>Controller: init SVGPaths (check/cross) if needed
Controller->>Controller: checkDirectory(path)
Note over Controller: returns DirectoryChecks {exists, canRead, canWrite}
Controller->>Labels: update each Label text, tooltip, styleClass
Controller->>SVG: set graphic to checkPath or crossPath based on each DirectoryCheck.status
deactivate Controller
Labels->>User: show check/cross + status messages
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🪛 Biome (2.1.2)owlplug-client/src/main/resources/owlplug.css[error] 14-14: Unknown property is not allowed. See CSS Specifications and browser specific properties for more details. (lint/correctness/noUnknownProperty) [error] 38-38: Unknown property is not allowed. See CSS Specifications and browser specific properties for more details. (lint/correctness/noUnknownProperty) [error] 42-42: Unknown property is not allowed. See CSS Specifications and browser specific properties for more details. (lint/correctness/noUnknownProperty) [error] 46-46: Unknown property is not allowed. See CSS Specifications and browser specific properties for more details. (lint/correctness/noUnknownProperty) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
owlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java(5 hunks)owlplug-client/src/main/resources/fxml/OptionsView.fxml(1 hunks)owlplug-client/src/main/resources/fxml/fragments/PluginPathFragment.fxml(1 hunks)owlplug-client/src/main/resources/owlplug.css(2 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
owlplug-client/src/main/resources/owlplug.css
[error] 14-14: Expected a color but instead found '#'.
Expected a color here.
Ensure the color is specified in a valid hexadecimal format. Examples: #000, #000f, #ffffff, #ffffffff
(parse)
[error] 14-14: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
[error] 42-42: Unknown property is not allowed.
See CSS Specifications and browser specific properties for more details.
To resolve this issue, replace the unknown property with a valid CSS property.
(lint/correctness/noUnknownProperty)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (7)
owlplug-client/src/main/resources/fxml/OptionsView.fxml (1)
30-30: LGTM - Layout density adjustment.The reduced spacing aligns well with the expanded plugin path UI that now includes validation warnings.
Also applies to: 33-33
owlplug-client/src/main/resources/owlplug.css (1)
41-43: LGTM - Consistent styling pattern.The
.label-warningclass follows the existing pattern for.label-dangerand.label-disabled. This will work correctly once thewarning-colorsyntax error on line 14 is fixed.owlplug-client/src/main/resources/fxml/fragments/PluginPathFragment.fxml (2)
3-14: LGTM - Improved import clarity and JavaFX upgrade.The explicit imports improve maintainability and the JavaFX 17 namespace update is appropriate.
32-39: LGTM - Warning label element properly configured.The
warningLabelis correctly set up for controller binding with appropriate styling and margin.owlplug-client/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java (3)
55-56: LGTM - Warning label field and initialization.The
warningLabelfield is properly declared and correctly initialized as hidden by default.Also applies to: 90-91
149-167: LGTM - Validation logic is sound.The directory validation checks cover the essential requirements: existence, type, and write permissions.
192-201: LGTM - Clean validation result types.The
DirectoryCheckResultrecord andDirectoryCheckStatusenum provide a type-safe, immutable structure for validation results.
...lient/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/com/owlplug/core/controllers/fragments/PluginPathFragmentController.java
Outdated
Show resolved
Hide resolved
DropSnorz
force-pushed
the
feat/perms-check
branch
from
2de9818 to
bf1ef02
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
Relates to #386