Merged
Conversation
Signed-off-by: Alexander Martinz <[email protected]>
The test was trying to look up index-v1.jar within the app's assets which does not contain it. Use the instrumentation package instead. Signed-off-by: Alexander Martinz <[email protected]>
The index converter never uses null and instead returns an empty list: - `donate = if (donate != null) listOf(donate) else emptyList()` Instead of adjusting this to return null, align with how `categories` is specified and default to an empty list instead. This also fixes the test V1SyncableTest#v1tov2. Signed-off-by: Alexander Martinz <[email protected]>
Iamlooker
requested changes
Jan 8, 2026
The v1 parser expects a jar file but v2 only provides json which results in the tests to break. This test also benchmarked the v1 performance twice, as a benchmark v1 test already exists. The tests are going to be reworked/obsolete in future refactorings anyways, so at least fix the test for now so the test suite completes successfully. Signed-off-by: Alexander Martinz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fixes a memory leak within the
V1Parserand fixes the instrumentation tests.