You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please check these things before merging this pull request:
Check if the Shizuku legacy installer supports Sui. If it does not then the mentions of Sui from the Shizuku legacy installer strings that mention it should be removed
I think the "System Black" theme should be called "System (black)"
Is the "Open Shizuku" string used for a button or something else that opens the Shizuku app or is it an instruction? If it is something that launches the Shizuku app then I think it should also be able to launch Sui and then string should say "Open Sui" if Sui is installed. If it is an instruction then I think it should be "Open Shizuku/Sui"
Make sure the README contents in the GitHub organization's description are changed to ones in this pull request
After the things mentioned above are checked I think this pull request will be ready to be merged.
What are the differences between the Shizuku installer and the legacy Shizuku installer?
What about this:
Is the "Open Shizuku" string used for a button or something else that opens the Shizuku app or is it an instruction? If it is something that launches the Shizuku app then I think it should also be able to launch Sui and then string should say "Open Sui" if Sui is installed. If it is an instruction then I think it should be "Open Shizuku/Sui"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
changed the title
ghost
marked this pull request as ready for review
This goals of this pull request are:
Improve the English translation in general
Make it clear that Sui is also supported for the Shizuku installer
Make more strings sentence case to follow the Material 3 style guide's UX writing best practices guidelines better (https://m3.material.io/foundations/content-design/style-guide/ux-writing-best-practices#fc5c2a78-f4bf-4d42-bdac-42ff80391129)
Skip periods and remove unnecessary punctuation to follow the Material 3 style guide's grammar and punctuation guidelines better (https://m3.material.io/foundations/content-design/style-guide/grammar-and-punctuation#555b17c7-de48-4974-8a82-51106899dc0e)
Use contractions when caution is not needed to follow the Material 3 style guide's grammar and punctuation guidelines better (https://m3.material.io/foundations/content-design/style-guide/grammar-and-punctuation#be900a2b-7194-44e3-aee7-ac01f8cec9ca)
Use hyphens with care to follow the Material 3 style guide's grammar and punctuation guidelines better (https://m3.material.io/foundations/content-design/style-guide/grammar-and-punctuation#ea3b187a-72a8-440c-9eb8-c774343c2b6b)
Please check these things before merging this pull request:
Check if the Shizuku legacy installer supports Sui. If it does not then the mentions of Sui from the Shizuku legacy installer strings that mention it should be removed
I think the "System Black" theme should be called "System (black)"
Is the "Open Shizuku" string used for a button or something else that opens the Shizuku app or is it an instruction? If it is something that launches the Shizuku app then I think it should also be able to launch Sui and then string should say "Open Sui" if Sui is installed. If it is an instruction then I think it should be "Open Shizuku/Sui"
Make sure the README contents in the GitHub organization's description are changed to ones in this pull request
After the things mentioned above are checked I think this pull request will be ready to be merged.