Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker build plumbing for the v26.3.10 release, ensuring Docker build arguments are correctly propagated from the launch script into the Dockerfile’s runtime stage.
Changes:
- Fix Bash array expansion when passing
DOCKER_PROGRAMSintoDOCKER_PROGRAMS_STRfor Docker/Compose/Podman builds. - Re-declare
ARG PYTHON_VERSIONin Dockerfile stage 2 so it’s available for later instructions (notably theCOPY ... python${PYTHON_VERSION} ...path).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ebook2audiobook.command | Passes the full DOCKER_PROGRAMS array as a space-separated string via DOCKER_PROGRAMS_STR. |
| Dockerfile | Adds ARG PYTHON_VERSION to the runtime stage to ensure ${PYTHON_VERSION} is defined for subsequent instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.