Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR rolls back the application version from 26.1.14 to 25.12.33 and addresses several issues related to progress tracking in audio processing functions and fixes a potential divide-by-zero edge case in VRAM detection.
Changes:
- Refactored progress tracking to use local variable
is_gui_processinstead of repeatedly accessingsession['is_gui_process'] - Updated
assemble_audio_chunks_worker()calls to include newprogress_queueandjob_idparameters - Consolidated progress tracking in
SubprocessPipeby removing duplicate_on_progress()method in favor of_emit_progress() - Added guard condition in
VRAMDetector._ceil_gb()to handle zero or negative byte values - Rolled back application version in Dockerfile from 26.1.14 to 25.12.33
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/core.py | Refactored is_gui_process usage and updated function calls with progress tracking parameters |
| lib/classes/subprocess_pipe.py | Removed duplicate _on_progress() method and consolidated progress reporting logic |
| lib/classes/vram_detector.py | Added safety check for negative/zero byte values in _ceil_gb() |
| Dockerfile | Version rollback from 26.1.14 to 25.12.33 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.