Skip to content

v25.12.33#1525

Merged
ROBERT-MCDOWELL merged 2 commits intoDrewThomasson:v25from
ROBERT-MCDOWELL:v25
Jan 13, 2026
Merged

v25.12.33#1525
ROBERT-MCDOWELL merged 2 commits intoDrewThomasson:v25from
ROBERT-MCDOWELL:v25

Conversation

@ROBERT-MCDOWELL
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 15:51
@ROBERT-MCDOWELL ROBERT-MCDOWELL merged commit 7509e99 into DrewThomasson:v25 Jan 13, 2026
2 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the VRAM detection logic to standardize memory reporting using ceiling values in GB (integers) instead of rounded floats, improving consistency across different device types.

Changes:

  • Replaced _gb() method with _ceil_gb() that returns integer GB values using math.ceil()
  • Renamed human-readable fields (allocated_human, reserved_human) to consistent naming (allocated_vram_gb, reserved_vram_gb)
  • Refactored Docker/CPU fallback logic to execute after all device-specific checks instead of within the try block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/classes/vram_detector.py
Comment thread lib/classes/vram_detector.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants