Conversation
There was a problem hiding this comment.
Pull request overview
This PR contains minor bug fixes and consistency improvements across error messages, variable naming, and script syntax. The changes primarily focus on correcting error message formatting and ensuring consistency in variable naming conventions.
- Error message corrections in voice_extractor.py (function name fixes, punctuation consistency, f-string formatting)
- Shell script variable naming consistency change from lowercase to uppercase
- Windows batch file modifications to improve string handling in pip installation loop
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/classes/voice_extractor.py | Corrects error messages: fixes function name in error message, standardizes punctuation from colons to periods, and adds missing f-string prefix for proper variable interpolation |
| ebook2audiobook.sh | Updates variable naming from lowercase current_pyvenv to uppercase CURRENT_PYVENV for consistency with usage on line 800 |
| ebook2audiobook.cmd | Modifies pip installation loop: changes substring syntax and adds quotes around package variable for safer handling of package names with spaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| set count_pkg=0 | ||
| for /f "usebackq delims=" %%P in ("%SCRIPT_DIR%\requirements.txt") do ( | ||
| if not "%%P"=="" if not "%%P:~0,1%"=="#" ( | ||
| if not "%%P"=="" if not "%%P:~0,1"=="#" ( |
There was a problem hiding this comment.
The closing percent sign '%' should not be removed from the substring operation. In Windows batch files, the correct syntax for substring extraction is %%P:~0,1% (with the closing %), not %%P:~0,1. Removing the closing percent sign will cause a syntax error.
| if not "%%P"=="" if not "%%P:~0,1"=="#" ( | |
| if not "%%P"=="" if not "%%P:~0,1%"=="#" ( |
No description provided.