Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR includes minor bug fixes and consistency improvements across error messages, variable naming, and script syntax. The changes focus on correcting error message inconsistencies, fixing string formatting issues, and improving variable name conventions.
- Fixed error message function name references and f-string formatting in voice extraction
- Corrected variable naming case consistency in shell script
- Fixed batch file substring syntax and added quotes for safer variable handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/classes/voice_extractor.py | Corrects error message function name from normalize_audio() to _convert2wav() on line 58, changes colons to periods for consistency, and fixes missing f-string prefix on line 265 |
| ebook2audiobook.sh | Updates variable naming from lowercase current_pyvenv to uppercase CURRENT_PYVENV for consistency with the rest of the script |
| ebook2audiobook.cmd | Fixes substring syntax from %%P:~0,1% to %%P:~0,1 and adds quotes around %%P variable for safer handling of package names with special characters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.