Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (v25.12.19) contains refactoring and bug fixes focused on subprocess handling and dependency management. The main changes simplify error handling in audio processing methods and fix package installation commands.
- Refactored
SubprocessPipeusage in voice extraction methods to remove redundant return value checks - Removed unused
tqdmimport fromsubprocess_pipe.py - Fixed conda command flag and added numpy version constraint for Jetson device installations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/classes/voice_extractor.py | Simplified error handling logic in _convert2wav, _demucs_voice, and normalize_audio methods by removing intermediate variable checks for SubprocessPipe calls |
| lib/classes/subprocess_pipe.py | Removed unused tqdm import (progress tracking handled via gradio's track_tqdm parameter) |
| lib/classes/device_installer.py | Fixed conda install command flag from '-d' to '-c' and added numpy<2 constraint for torch versions <= 2.2.2 on Jetson devices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.