Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR (v25.12.16) includes changes to enhance GPU detection reliability and add compatibility workarounds for PyTorch's distributed module. The changes refactor GPU detection logic into reusable helper functions and adjust package installation flags.
Key Changes:
- Added monkey-patching for PyTorch's distributed module to handle installations without distributed support
- Refactored GPU detection logic into separate helper functions (
has_working_cuda(),has_working_rocm(),has_working_xpu(), and corresponding PCI detection functions) - Removed
--use-pep517flag from bash script pip installation command
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/classes/tts_engines/coqui.py | Adds compatibility layer for PyTorch installations lacking torch.distributed module |
| lib/classes/device_installer.py | Refactors GPU detection into modular helper functions and reorders detection priority (ROCm before CUDA) |
| ebook2audiobook.sh | Removes --use-pep517 flag from pip install command in bash script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.