Repository navigation
Commit 850e6a4
fix: derive user-facing docs links from the live instance, else drop (TKT-414) (#52)
* fix(app,core,cli): derive user-facing docs links from the live instance, else drop (TKT-414)
TKT-397 fixed the model-facing prompt files; this closes the 5 user-facing
surfaces from feedback anomalyco#208 with the same mechanism and the same failure
mode: opencode.ai/docs describes upstream, not this fork.
- desktop-menu.ts's Documentation entry now dispatches through the desktop
command registry (docs.open) instead of a static href, matching the
exportLogs precedent. DesktopCommands() derives <connected-server>/docs
via a new pure desktopDocsUrl() helper and opens it with
platform.openExternal; the command is only offered while a server is
actually connected.
- providers.ts's Cloudflare AI Gateway hint and github.handler.ts's
`github install` outro are both standalone-CLI surfaces with no live
server instance -- URL dropped, prose kept.
- config.ts's `command`/`agent` schema descriptions (editor tooltips, no
runtime instance context) -- URL dropped, prose kept.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01M1CJmqai46ihahdKMVNB27
* fix(app): register docs.open unconditionally, honest toast when disconnected (TKT-414 review)
Peer review (Henry) found the macOS native menu has no per-command
enabled/disabled plumbing (packages/desktop/src/main/menu.ts's nativeItem
only special-cases "updater"), so gating the command's registration on a
connected server left the item always clickable there and silently doing
nothing when disconnected -- presence without function, worse than the
"absence over wrongness" the ticket asks for. Windows already disables it
correctly via commandDisabled, but the fix should not depend on which
native menu implementation is rendering it.
Register docs.open unconditionally on desktop; onSelect resolves the URL
at click time and opens it, or shows a toast naming why it can't
("Documentation is served by a running instance...") when no server is
connected. One more i18n key (command.docs.unavailable), same
pending-first-attempt bookkeeping as command.docs.open.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01M1CJmqai46ihahdKMVNB27
* docs(web): relink two shipped docs pages within the docs bundle, not to upstream (TKT-414 review)
mcp-servers.mdx and plugins.mdx used absolute https://opencode.ai/docs/...
links where every other page in this same directory uses the established
root-relative /docs/... convention. Both files ship inside the embedded
docs bundle TKT-391 serves at this build's own /docs -- the absolute form
reopened the loop TKT-397/#47 closed one level down: the model is told to
trust this instance's own docs, and one level inside them a link sent the
reader back to upstream. Mechanical fix, matching the convention already
used by every sibling page (config.mdx, sdk.mdx, etc.).
Per Ethan/Henry's review: the READMEs and install script from a separate
audit (anomalyco#220) are explicitly out of scope here -- a product decision for
the consolidation round, not touched.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01M1CJmqai46ihahdKMVNB27
---------
Co-authored-by: opencode <[email protected]>
Co-authored-by: Claude Sonnet 5 <[email protected]>1 parent f7c543c commit 850e6a4
12 files changed
Lines changed: 205 additions & 11 deletions
File tree
- packages
- app/src
- i18n
- core/src/v1/config
- opencode/src/cli/cmd
- web/src/content/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
331 | 333 | | |
332 | 334 | | |
333 | 335 | | |
| 336 | + | |
334 | 337 | | |
335 | 338 | | |
336 | 339 | | |
| |||
344 | 347 | | |
345 | 348 | | |
346 | 349 | | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
347 | 370 | | |
348 | 371 | | |
349 | 372 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
14 | 23 | | |
15 | 24 | | |
16 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
| 282 | + | |
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
41 | 44 | | |
42 | | - | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
106 | 109 | | |
107 | 110 | | |
108 | 111 | | |
109 | | - | |
| 112 | + | |
110 | 113 | | |
111 | 114 | | |
112 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
196 | 199 | | |
197 | 200 | | |
198 | 201 | | |
| |||
201 | 204 | | |
202 | 205 | | |
203 | 206 | | |
204 | | - | |
205 | | - | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
472 | 472 | | |
473 | 473 | | |
474 | 474 | | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
475 | 478 | | |
476 | | - | |
| 479 | + | |
477 | 480 | | |
478 | 481 | | |
479 | 482 | | |
| |||
0 commit comments