Repository navigation
Commit 5e1a90f
fix(monitor): nullish, not truthy, checks on epoch-millis timestamp fields
Henry (via Copilot's suppressed-but-verified finding, 4913451058): fromRow
read time_started/time_checked/time_finished with a truthy check, so an
epoch-millis value of 0 -- a real timestamp -- misread as unset. Live under
TestClock (starts at epoch 0), silently, because no existing assertion
touched a timestamp field.
Fixed to `!= null`. Added one assertion (recover marks every starting/
running row orphaned) asserting time.finished is defined on the orphaned
rows -- confirmed it fails without the fix (TestClock's epoch-0
time_finished read back as undefined) and passes with it.
Co-Authored-By: Claude <[email protected]>1 parent 5af6f0c commit 5e1a90f
2 files changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
125 | 129 | | |
126 | 130 | | |
127 | 131 | | |
| |||
0 commit comments