Repository navigation
Commit 2eeb091
ci(fork): make CI green-means-green -- blacksmith sweep, unit reds fixed (#11)
* ci(fork): retarget/disable blacksmith runners, stabilize windows/linux unit reds
TKT-336, part 1: work-in-progress commit to get real CI evidence before
finalizing FORK.md. Squashed/reworded before merge.
Blacksmith-runner sweep (18+ workflow files queued forever, no Blacksmith
GitHub App on this org):
- test.yml e2e job: retargeted to ubuntu-latest/windows-latest. Real
Playwright coverage, and the literal cause of "held open" workflow
runs blocking rerun-failed-jobs for every job in the same run.
- storybook.yml, notify-discord.yml: retargeted (real, cheap checks).
- nix-eval.yml, nix-hashes.yml, generate.yml, docs-update.yml,
docs-locale-sync.yml, publish.yml, publish-github-action.yml,
publish-vscode.yml, containers.yml, release-github-action.yml,
beta.yml: auto-triggers disabled (workflow_dispatch kept as escape
hatch). Not this fork's concern (nix packaging, docs sync) or a
safety choice (real npm/container/marketplace publish pipelines with
write credentials -- an internal redesign fork should not auto-publish
under the org's name).
- pr-management.yml (check-duplicates), review.yml, opencode.yml:
job-level `if: false`, not just runner-blocked -- also missing
OPENCODE_API_KEY (already documented in FORK.md for review.yml).
- duplicate-issues.yml, triage.yml: untouched, already fully inert
(has_issues: false on this repo, issues: events can never fire).
- stats.yml: untouched, already self-excludes via
`if: github.repository == 'anomalyco/opencode'`.
unit (linux): the anomalyco#27371 fast-fail regression test skipped (not
widened -- widening the 15s assertion would mask the specific failure
mode feedback anomalyco#136 suspects, not just add margin), comment links anomalyco#136
and the un-skip condition.
unit (windows) mode A: packages/core's test script had no --timeout
override at all (bun's raw 5000ms default), unlike opencode/tui which
already use --timeout 30000. Every test FORK.md documented as a mode-A
failure (Ripgrep, i18n parity, Git worktrees/trees, LocationServiceMap,
MoveSession) lives in packages/core -- confirmed via grep, not
assumed. Added --timeout 30000, matching the established fork
convention elsewhere.
Not yet verified against real CI (that's this commit's purpose) or
reflected in FORK.md's known-red table -- both follow once 2-3 windows
runs confirm whether the core timeout fix alone stabilizes it.
Co-Authored-By: Claude <[email protected]>
* ci(fork): skip windows unit tests -- timeout raise exposed a real Ripgrep bug
First real CI run of TKT-336's changes showed the packages/core timeout
fix (30s override) genuinely stabilized the mode-A "varying subset"
flakiness -- i18n parity, Git worktrees/trees, LocationServiceMap, and
MoveSession all passed. But Ripgrep's 4 tests still failed, now timing
out at exactly 30000ms instead of ~5000ms, with "Ripgrep.Error:
ripgrep execution failed" in the log -- a real, deterministic
execution failure on windows-latest, not a timing margin issue that
more rope would fix.
RipgrepBinary's Windows path downloads a zip and extracts it via
PowerShell at first use (packages/core/src/ripgrep/binary.ts) --
root-causing that is real production-code debugging, out of scope for
a CI-hygiene ticket. Filed as feedback anomalyco#152 with the full evidence.
Per the ticket's own stated fallback ("skip the windows unit job
entirely with a stated rationale if timeouts alone do not stabilize
it"), the "Run unit tests" step is now Linux-only. check:generated and
test:httpapi were already Linux-only; nothing else runs on Windows in
this job now, so it reports a clean pass instead of vanishing or
red.
Co-Authored-By: Claude <[email protected]>
* docs(fork): rewrite FORK.md for the green-means-green gate
TKT-336, final: rebased onto dev@441ad185 (Gemma's #10) confirmed
feedback anomalyco#145 (v2.session.goal.get, mode=effect) is dead -- test:httpapi
--mode effect went from 226/1 to 229/0, zero exceptions needed. Ethan's
ruling: check reachability before building new skip machinery, and it
paid off -- no per-mode scenario skip needed after all.
FORK.md rewritten to match: the known-red-exceptions table becomes
"Resolved CI reds" (history, not a live lookup), the milestone-1 gate
section becomes "the merge gate: all green, any red blocks" per the
operator's directive, and a new "Blacksmith runner sweep" section
records every workflow's retarget/disable/if:false/untouched
disposition with rationale, matching the pattern the ticket asked for
(comment + un-skip condition at every change).
Co-Authored-By: Claude <[email protected]>
* ci(fork): skip e2e (windows) too -- systemic Playwright failures on first run
e2e (windows) also never ran before TKT-336 (queued forever on
blacksmith). Retargeting it to windows-latest was its first real
execution, and it surfaced ~40 distinct e2e/regression/*.spec.ts
failures ("element(s) not found" / toBeVisible timeouts), consistent
across Playwright's own automatic retries. e2e (linux), the identical
suite on ubuntu-latest in the same run, passed cleanly -- Windows-
specific, and the volume/consistency reads as systemic rather than 40
independent app bugs.
Same boundary as the Ripgrep-on-Windows unit finding: real E2E-
environment debugging, out of scope for a CI-hygiene ticket. Filed as
feedback anomalyco#156 with the run's artifact link (screenshots + traces).
"Run app e2e tests" is now Linux-only; e2e (linux) stays in the gate,
e2e (windows) reports green without asserting anything until anomalyco#156 is
root-caused.
FORK.md updated: new row in "Resolved CI reds", gate section corrected
to say e2e (linux) only, not both platforms.
Co-Authored-By: Claude <[email protected]>
* ci(fork): move e2e out of the gate entirely -- corrected reading, symmetric
Ethan's ruling on the corrected e2e data (feedback anomalyco#156): the
"~40 systemic Windows failures" reading was wrong -- a grep artifact
counting Playwright's test-discovery listing, not real failures. Real
count: 2 failed/87 passed on Windows, then 1 failed/96 passed on a
later Linux run (previously clean twice), different spec each time.
Ordinary, low-rate E2E flakiness on both platforms, pre-existing and
never observed before (e2e never ran on either platform pre-TKT-336).
Un-skips the Windows e2e execution step (symmetry -- both platforms
run, both observational, or the asymmetry itself misleads the next
reader) and moves e2e out of the merge gate on BOTH platforms rather
than reintroducing a Windows-only exception. The gate is now
typecheck + unit(both) + test:httpapi.
e2e stays running (not disabled) with a deterministic reading rule in
FORK.md, so "observational" doesn't become "advisory and ignored" --
the exact trap this ticket exists to close: the SAME spec failing 3
consecutive runs is a real regression, filed no-judgment-required;
scattered single-spec flakes across different specs are not.
Stabilizing genuine Playwright flakiness belongs to the milestone-3
real-browser-matrix slice, not a CI-hygiene ticket.
Co-Authored-By: Claude <[email protected]>
---------
Co-authored-by: Felicity <[email protected]>
Co-authored-by: Claude <[email protected]>1 parent 6ff63c5 commit 2eeb091
20 files changed
Lines changed: 292 additions & 146 deletions
File tree
- .github/workflows
- packages
- core
- opencode/test/cli/run
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
3 | 8 | | |
4 | 9 | | |
5 | | - | |
6 | | - | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
3 | 9 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
3 | 8 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
3 | 9 | | |
4 | | - | |
5 | | - | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
3 | 11 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 12 | + | |
7 | 13 | | |
8 | 14 | | |
9 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
3 | 10 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
6 | 11 | | |
7 | 12 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | 13 | | |
20 | 14 | | |
21 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
10 | 15 | | |
11 | 16 | | |
12 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
11 | 18 | | |
12 | | - | |
| 19 | + | |
| 20 | + | |
13 | 21 | | |
14 | 22 | | |
15 | | - | |
| 23 | + | |
16 | 24 | | |
17 | 25 | | |
18 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
9 | 19 | | |
10 | 20 | | |
11 | 21 | | |
| |||
0 commit comments