Skip to content

Improved fix 449#646

Merged
sharwell merged 2 commits intoDotNetAnalyzers:masterfrom
sharwell:improved-fix-449
Apr 23, 2015
Merged

Improved fix 449#646
sharwell merged 2 commits intoDotNetAnalyzers:masterfrom
sharwell:improved-fix-449

Conversation

@sharwell
Copy link
Member

@sharwell sharwell commented Apr 7, 2015

Fixes #449 by using an elastic marker only when the trivia list starts out empty.

Supersedes #453.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concat can be replaced with AddRange here as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, GetAllTrivia() returns an IEnumerable<SyntaxTrivia>.

@pdelvo
Copy link
Member

pdelvo commented Apr 23, 2015

Looks good to me!

sharwell added a commit that referenced this pull request Apr 23, 2015
@sharwell sharwell merged commit fc008ad into DotNetAnalyzers:master Apr 23, 2015
@sharwell sharwell deleted the improved-fix-449 branch April 23, 2015 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SA1119 code fix needs to add whitespaces

2 participants