SA1502 implementation (incl. tests + codefix)#547
Merged
sharwell merged 12 commits intoDotNetAnalyzers:masterfrom May 10, 2015
Merged
SA1502 implementation (incl. tests + codefix)#547sharwell merged 12 commits intoDotNetAnalyzers:masterfrom
sharwell merged 12 commits intoDotNetAnalyzers:masterfrom
Conversation
…clarations, and namespace declarations
Member
There was a problem hiding this comment.
If Im not missing something you can change HandleTypeDeclarations to look for BaseTypeDeclarationSyntax. Then it can handle EnumDeclaration too.
Contributor
Author
There was a problem hiding this comment.
That will work, yes. I'll change that.
Member
|
Im always amazed how much work you put into the unit tests 👍 |
Member
|
I think this can be merged when the change to the indentation is reverted 👍 |
Contributor
Author
|
I reverted the indentation change. I wasn't aware it was changed, I guess Visual Studio formatting caught me by surprise 😄 |
Member
|
Yes Visual Studio indents these automaticaly. You can be changed in the options if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103