Skip to content

Added extension point to DiagnosticVerifier#522

Merged
sharwell merged 3 commits intoDotNetAnalyzers:masterfrom
vweijsters:TestExtension
Jul 12, 2015
Merged

Added extension point to DiagnosticVerifier#522
sharwell merged 3 commits intoDotNetAnalyzers:masterfrom
vweijsters:TestExtension

Conversation

@vweijsters
Copy link
Contributor

Added the CreateSolution extension point to the DiagnosticsVerifier, in order to get control over solution properties.

@sharwell
Copy link
Member

@vweijsters I would prefer to wait on this for now. Do you mind if I close it as wontfix until such time as we hit a case that is substantially impacted by it?

@vweijsters
Copy link
Contributor Author

SA1502 (#547) uses this to test the indentation code in the code fixer.
If we are okay with only testing for 4 spaces indentation in the unit tests, then I'm fine with closing this.

@sharwell
Copy link
Member

Thanks, I'll keep this open at least until I review that. 😄

@vweijsters
Copy link
Contributor Author

Merged in upstream/master

@pdelvo
Copy link
Member

pdelvo commented Jun 22, 2015

I could use this to add a test for #929.

@pdelvo pdelvo mentioned this pull request Jun 25, 2015
@sharwell sharwell merged commit 0ea6fde into DotNetAnalyzers:master Jul 12, 2015
@sharwell sharwell added this to the 1.0.0 Alpha 11 milestone Jul 12, 2015
@sharwell sharwell self-assigned this Jul 12, 2015
@vweijsters vweijsters deleted the TestExtension branch July 12, 2015 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants